cloud-fan commented on a change in pull request #31337:
URL: https://github.com/apache/spark/pull/31337#discussion_r571986698
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/commands.scala
##########
@@ -157,7 +156,7 @@ case class ExplainCommand(
override def run(sparkSession: SparkSession): Seq[Row] = try {
val outputString =
sparkSession.sessionState.executePlan(logicalPlan).explainString(mode)
Seq(Row(outputString))
- } catch { case cause: TreeNodeException[_] =>
+ } catch { case cause: AnalysisException =>
Review comment:
we should probably catch `NonFatal` now
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/commands.scala
##########
@@ -179,7 +178,7 @@ case class StreamingExplainCommand(
queryExecution.simpleString
}
Seq(Row(outputString))
- } catch { case cause: TreeNodeException[_] =>
+ } catch { case cause: AnalysisException =>
Review comment:
ditto
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
