cloud-fan commented on a change in pull request #30869: URL: https://github.com/apache/spark/pull/30869#discussion_r572030438
########## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/FileFormat.scala ########## @@ -162,6 +162,8 @@ trait FileFormat { * By default all data types are supported. */ def supportDataType(dataType: DataType): Boolean = true + + def checkFieldNames(names: Seq[String]): Unit = {} Review comment: Can we add some document for this API? We can probably require the exception type as `AnalysisException` ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org