HeartSaVioR commented on pull request #31520: URL: https://github.com/apache/spark/pull/31520#issuecomment-775566881
I'm sorry I haven't considered about the impact of extracting the code - logger. I'm not sure we are leveraging the information on classname difference for tracking log on committing in practice. Let's just make sure others are OK with this, otherwise I might ask you to unroll the change. Sorry again. cc. @LuciferYang @HyukjinKwon @yaooqinn @dongjoon-hyun (reviewers on #31471) I assume you have interest on the commit log message, and probably dealing with it in production. Would retaining the caller site help you or no matter which logger will log it? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
