gerashegalov commented on pull request #31540: URL: https://github.com/apache/spark/pull/31540#issuecomment-777098664
Thanks for taking a look @mridulm correct, this patch does not address the problem in general, it just mitigates it for `CollectionAccumulator` and its subclass `PythonAccumulatorV2`. Any solution relying on readObject to publish the object including the one you propose will publish the object too early. A generally correct solution that will work for user-defined Accumulators as well must not rely on readObject imo, and it is more involved. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
