HyukjinKwon commented on pull request #31541: URL: https://github.com/apache/spark/pull/31541#issuecomment-777155208
@rdblue, sure, I can change the PR description if that looks an issue to you. This is not merged yet so I can change. Can you please answer my question first though? First, the previous PR was not an incremental improvement. It caused a regression in the most common scenario with the default Spark session. Second, it should have the test cases to prove that it works. Third, the PR description should clarify what the change targets to fix, and why. It does not look obvious to me, presumably to other people given their comments. Forth, people already raised concerns of the merge process and pointed out several issues in the PR. Last, the PR was merged without people's opinion, which harms the community. If you want to keep the community healthy, we should revert the output from that action immediately. New PR should better be created, and should be discussed from scratch. You're assuming that the output from that action does not harm the community health. This remains as a bad example, and we will have to repeat the same thing if it happens again next time. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
