viirya commented on a change in pull request #31567: URL: https://github.com/apache/spark/pull/31567#discussion_r577306759
########## File path: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/optimizer/LimitPushdownSuite.scala ########## @@ -194,4 +194,22 @@ class LimitPushdownSuite extends PlanTest { LocalLimit(1, y.groupBy(Symbol("b"))(count(1))))).analyze comparePlans(expected2, optimized2) } + + test("SPARK-26138: pushdown limit through InnerLike when condition is empty") { Review comment: Shall we have a e2e test to check answer too? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org