cloud-fan commented on pull request #31569: URL: https://github.com/apache/spark/pull/31569#issuecomment-783231459
> Replace ' syntax with $"" or col() in examples and documents. +1. This can be done first. > Deprecate APIs which take Symbol type parameters. The API doesn't take Symbol, but Spark has built-in implicits to convert `Symbol` to `Column`. Does it really work to deprecate an implicit? For the tests, I don't have a strong opinion, as it's not a blocker. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
