beliefer edited a comment on pull request #31390: URL: https://github.com/apache/spark/pull/31390#issuecomment-783233306
@cloud-fan @gengliangwang There not any database do `trim(binary) => string`, so I think should remove the `ImplicitCastInputTypes` from `String2TrimExpression`. In PostgreSQL, the behavior is ``` trim(String) => String trim(Binary) => Binary ``` If you agree it, I will make a PR to fix it. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
