cloud-fan commented on a change in pull request #31595:
URL: https://github.com/apache/spark/pull/31595#discussion_r581618520
##########
File path: sql/core/src/test/scala/org/apache/spark/sql/SubquerySuite.scala
##########
@@ -1013,118 +1014,120 @@ class SubquerySuite extends QueryTest with
SharedSparkSession with AdaptiveSpark
}
test("SPARK-23957 Remove redundant sort from subquery plan(in subquery)") {
- withTempView("t1", "t2", "t3") {
- Seq((1, 1), (2, 2)).toDF("c1", "c2").createOrReplaceTempView("t1")
- Seq((1, 1), (2, 2)).toDF("c1", "c2").createOrReplaceTempView("t2")
- Seq((1, 1, 1), (2, 2, 2)).toDF("c1", "c2",
"c3").createOrReplaceTempView("t3")
-
- // Simple order by
- val query1 =
- """
- |SELECT c1 FROM t1
- |WHERE
- |c1 IN (SELECT c1 FROM t2 ORDER BY c1)
+ withSQLConf(SQLConf.OPTIMIZER_EXCLUDED_RULES.key ->
RemoveNoopUnion.ruleName) {
Review comment:
what happens to this test?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
