Github user liancheng commented on a diff in the pull request:

    https://github.com/apache/spark/pull/5505#discussion_r29122071
  
    --- Diff: 
sql/hive/src/test/scala/org/apache/spark/sql/hive/parquetSuites.scala ---
    @@ -688,7 +688,7 @@ class ParquetDataSourceOnSourceSuite extends 
ParquetSourceSuiteBase {
         sql("DROP TABLE alwaysNullable")
       }
     
    -  test("Aggregation attribute names can't contain special chars \" 
,;{}()\\n\\t=\"") {
    +  ignore("Aggregation attribute names can't contain special chars \" 
,;{}()\\n\\t=\"") {
    --- End diff --
    
    I guess it should be OK to disable or even remove this test now, since now 
we check for invalid field names explicitly and suggest users to add aliases. 
See #5263.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to