[GitHub] [spark] srowen commented on a change in pull request #31648: [SPARK-34541][core]Fixed an issue where data could not be cleaned up when unregisterShuffle.

[GitBox]

srowen commented on a change in pull request #31648:
URL: https://github.com/apache/spark/pull/31648#discussion_r582890410



##########
File path: 
core/src/main/scala/org/apache/spark/shuffle/sort/SortShuffleManager.scala
##########
@@ -154,7 +154,7 @@ private[spark] class SortShuffleManager(conf: SparkConf) 
extends ShuffleManager
       metrics: ShuffleWriteMetricsReporter): ShuffleWriter[K, V] = {
     val mapTaskIds = taskIdMapsForShuffle.computeIfAbsent(
       handle.shuffleId, _ => new OpenHashSet[Long](16))
-    mapTaskIds.synchronized { mapTaskIds.add(context.taskAttemptId()) }

Review comment:
       @xuanyuanking do you have an opinion here? I think you wrote this piece 
of the code.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org