xkrogen commented on pull request #31642: URL: https://github.com/apache/spark/pull/31642#issuecomment-786035316
This seems like a decent workaround, but is it the right long-term fix? It seems like depending on the non-shaded JAR breaks the benefits of leveraging only the shaded `hadoop-client-api` and `hadoop-client-runtime` JARs. Should `AmIpFilter` be a public class, i.e., is it something AMs are expected to leverage? If yes -- can we get it moved to `hadoop-client-runtime`? If no -- should we stop using it here and re-implement some of the required logic ourselves? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
