xuanyuanking commented on a change in pull request #31643:
URL: https://github.com/apache/spark/pull/31643#discussion_r583374620
##########
File path:
common/network-shuffle/src/main/java/org/apache/spark/network/shuffle/OneForOneBlockFetcher.java
##########
@@ -117,17 +117,23 @@ private FetchShuffleBlocks createFetchShuffleBlocksMsg(
boolean batchFetchEnabled = firstBlock.length == 5;
HashMap<Long, ArrayList<Integer>> mapIdToReduceIds = new HashMap<>();
+ ArrayList<Long> orderedMapId = new ArrayList<>();
Review comment:
Please add more comments here to emphasize why we need ordered map id
here.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
