Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/5664#discussion_r29176345
--- Diff: core/src/main/scala/org/apache/spark/ui/JettyUtils.scala ---
@@ -231,6 +259,46 @@ private[spark] object JettyUtils extends Logging {
ServerInfo(server, boundPort, collection)
}
+ // Create a new URI from the arguments, handling IPv6 host encoding and
default ports. Based on:
+ //
https://github.com/eclipse/jetty.project/blob/master/jetty-util/src/main/java/org/eclipse/
+ // jetty/util/URIUtil.java#L726-L733
+ private def newURI(scheme: String, server: String, port: Int, path:
String, query: String) = {
--- End diff --
This is OK but it could be simple if you used the
[URI](http://docs.oracle.com/javase/8/docs/api/java/net/URI.html#URI-java.lang.String-java.lang.String-java.lang.String-java.lang.String-java.lang.String-)
class.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
