cloud-fan commented on a change in pull request #31749: URL: https://github.com/apache/spark/pull/31749#discussion_r589257679
########## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/parser/AstBuilder.scala ########## @@ -1144,7 +1144,9 @@ class AstBuilder extends SqlBaseBaseVisitor[AnyRef] with SQLConfHelper with Logg } val tvf = UnresolvedTableValuedFunction( - func.funcName.getText, func.expression.asScala.map(expression).toSeq, aliases) + getFunctionIdentifier(func.functionName), Review comment: shall we make sure the `database` part is None to be consistent with before? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org