cloud-fan commented on a change in pull request #31783: URL: https://github.com/apache/spark/pull/31783#discussion_r590039084
########## File path: sql/core/src/test/scala/org/apache/spark/sql/execution/SQLViewTestSuite.scala ########## @@ -293,22 +295,45 @@ abstract class SQLViewTestSuite extends QueryTest with SQLTestUtils { } } } + + test("SPARK-34152: view's identifier should be correctly stored") { + Seq(true, false).foreach { storeAnalyzed => + withSQLConf(STORE_ANALYZED_PLAN_FOR_VIEW.key -> storeAnalyzed.toString) { Review comment: it's ok to have a little waste in the test. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org