maropu commented on a change in pull request #31836:
URL: https://github.com/apache/spark/pull/31836#discussion_r595716452
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/arithmetic.scala
##########
@@ -145,18 +145,39 @@ case class UnaryPositive(child: Expression)
""",
since = "1.2.0",
group = "math_funcs")
-case class Abs(child: Expression)
+case class Abs(child: Expression, failOnError: Boolean =
SQLConf.get.ansiEnabled)
Review comment:
Does the interpreted code has the same behaviour?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
