HeartSaVioR commented on a change in pull request #31495:
URL: https://github.com/apache/spark/pull/31495#discussion_r596428960
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/CheckpointFileManager.scala
##########
@@ -277,7 +277,6 @@ class FileSystemBasedCheckpointFileManager(path: Path,
hadoopConf: Configuration
fs.delete(path, true)
} catch {
case e: FileNotFoundException =>
- logInfo(s"Failed to delete $path as it does not exist")
Review comment:
I've already experimented and noticed both will have no noticeable
difference.
https://github.com/apache/spark/pull/31495#discussion_r572473687
But that's completely based on implementation details; implementations can
leverage the benefit of doing less operations if external storage could simply
do what the operation associated with delete promises the same contract
delete() in Hadoop filesystem promises.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
