zhengruifeng edited a comment on pull request #31889: URL: https://github.com/apache/spark/pull/31889#issuecomment-802462693
I also test using the two new agg in `LogisticRegressionSuite`, and all test passed except "multinomial logistic regression with intercept with L1 regularization": existing [`interceptsRStd`](https://github.com/apache/spark/blob/master/mllib/src/test/scala/org/apache/spark/ml/classification/LogisticRegressionSuite.scala#L1816) is NOT equals to the [R coef](https://github.com/apache/spark/blob/master/mllib/src/test/scala/org/apache/spark/ml/classification/LogisticRegressionSuite.scala#L1753-L1779) To pass this case, I need to change `interceptsRStd` to the output of GLMNET, that is [-0.69265374, -0.2260274, 0.9186811]. But I think this should be a good change, since mlor's solution is more close to GLMNET. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
