MaxGekk commented on a change in pull request #31917:
URL: https://github.com/apache/spark/pull/31917#discussion_r598438961
##########
File path: sql/core/benchmarks/CSVBenchmark-results.txt
##########
@@ -2,66 +2,66 @@
Benchmark to measure CSV read/write performance
================================================================================================
-OpenJDK 64-Bit Server VM 1.8.0_252-8u252-b09-1~18.04-b09 on Linux
4.15.0-1063-aws
-Intel(R) Xeon(R) CPU E5-2670 v2 @ 2.50GHz
+Java HotSpot(TM) 64-Bit Server VM 1.8.0_202-b08 on Mac OS X 10.15.7
Review comment:
> I don't think it matters.
You changed almost everything in the environment: CPU, memory, OS, JVM. Also
you run the benchmark on your laptop, it seems. For instance, this impacts on
`Stddev`, it became bigger because other processes (or some other activities in
your laptop) influenced on the benchmark.
One more thing, if you look at existing benchmark results. Almost all of
them were launched in the same environment. In my PRs and @dongjoon-hyun 's
PRs, we pointed out the environment, see
https://github.com/apache/spark/pull/30118,
https://github.com/apache/spark/pull/28613.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
