maropu commented on a change in pull request #31940:
URL: https://github.com/apache/spark/pull/31940#discussion_r600026596
##########
File path:
sql/core/src/test/scala/org/apache/spark/sql/CharVarcharTestSuite.scala
##########
@@ -631,6 +616,45 @@ trait CharVarcharTestSuite extends QueryTest with
SQLTestUtils {
checkAnswer(spark.table("t"), Row("c "))
}
}
+
+ test("SPARK-34833: right-padding applied correctly for correlated subqueries
- join keys") {
+ withTable("t1", "t2") {
+ sql(s"CREATE TABLE t1(v VARCHAR(3), c CHAR(5)) USING $format")
+ sql(s"CREATE TABLE t2(v VARCHAR(5), c CHAR(8)) USING $format")
+ sql("INSERT INTO t1 VALUES ('c', 'b')")
+ sql("INSERT INTO t2 VALUES ('a', 'b')")
+ Seq("t1.c = t2.c", "t2.c = t1.c", "t1.c = 'b'", "'b' = t1.c").foreach {
predicate =>
Review comment:
I added the longer case (I added more tests for the various patterns,
too)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
