dongjoon-hyun commented on a change in pull request #31945:
URL: https://github.com/apache/spark/pull/31945#discussion_r600151187
##########
File path:
core/src/main/scala/org/apache/spark/executor/ProcfsMetricsGetter.scala
##########
@@ -199,7 +201,7 @@ private[spark] class ProcfsMetricsGetter(procfsDir: String
= "/proc/") extends L
case f: IOException =>
logWarning("There was a problem with reading" +
" the stat file of the process. ", f)
- ProcfsMetrics(0, 0, 0, 0, 0, 0)
+ throw f
Review comment:
According to the proposal, we want to fail at the first `Exception`? Did
I understand correctly?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
