HeartSaVioR commented on a change in pull request #31355:
URL: https://github.com/apache/spark/pull/31355#discussion_r600880055
##########
File path:
sql/catalyst/src/main/java/org/apache/spark/sql/connector/write/RequiresDistributionAndOrdering.java
##########
@@ -42,6 +42,19 @@
*/
Distribution requiredDistribution();
+ /**
+ * Returns the number of partitions required by this write.
+ * <p>
+ * Implementations may override this to require a specific number of input
partitions.
+ * <p>
+ * Note that Spark doesn't support the number of partitions on {@link
UnspecifiedDistribution},
+ * if requiredDistribution() returns {@link UnspecifiedDistribution}, the
return value for this
+ * method will be ignored.
Review comment:
Let's make it fail so that the intention isn't silently ignored. Good
point.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
