HyukjinKwon commented on a change in pull request #31953:
URL: https://github.com/apache/spark/pull/31953#discussion_r601011588
##########
File path: core/src/main/scala/org/apache/spark/SparkContext.scala
##########
@@ -2186,13 +2186,22 @@ class SparkContext(config: SparkConf) extends Logging {
* has overridden the call site using `setCallSite()`, this will return the
user's version.
*/
private[spark] def getCallSite(): CallSite = {
- lazy val callSite = Utils.getCallSite()
- CallSite(
-
Option(getLocalProperty(CallSite.SHORT_FORM)).getOrElse(callSite.shortForm),
- Option(getLocalProperty(CallSite.LONG_FORM)).getOrElse(callSite.longForm)
- )
+ if (getLocalProperty(CallSite.SHORT_FORM) == null
Review comment:
@lxian, it would be great if we can elabourate how it causes the lock as
you did in JIRA. In addition, to clarify, this is not an issue in Spark 3+ as
we dropped Scala 2.11 at SPARK-26132.
Can you create a PR for bracnh-2.4 alone? cc @viirya and @dongjoon-hyun FYI
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
