cloud-fan commented on a change in pull request #30212:
URL: https://github.com/apache/spark/pull/30212#discussion_r601148662
##########
File path: docs/sql-ref-syntax-qry-select-groupby.md
##########
@@ -50,34 +65,28 @@ aggregate_name ( [ DISTINCT ] expression [ , ... ] ) [
FILTER ( WHERE boolean_ex
is a shorthand for a `UNION ALL` where each leg of the `UNION ALL`
operator performs aggregation of subset of the columns specified in the
`GROUPING SETS` clause.
-* **grouping_set**
-
- A grouping set is specified by zero or more comma-separated expressions in
parentheses.
-
- **Syntax:** `( [ expression [ , ... ] ] )`
-
-* **grouping_expression**
-
- Specifies the criteria based on which the rows are grouped together. The
grouping of rows is performed based on
- result values of the grouping expressions. A grouping expression may be a
column alias, a column position
- or an expression.
-
* **ROLLUP**
Specifies multiple levels of aggregations in a single statement. This
clause is used to compute aggregations
based on multiple grouping sets. `ROLLUP` is a shorthand for `GROUPING
SETS`. For example,
- `GROUP BY warehouse, product WITH ROLLUP` is equivalent to `GROUP BY
GROUPING SETS
- ((warehouse, product), (warehouse), ())`.
+ `GROUP BY warehouse, product WITH ROLLUP` is equivalent to `GROUP BY
ROLLUP(warehouse, product)` or
Review comment:
nit:
```
`GROUP BY warehouse, product WITH ROLLUP` or `GROUP BY ROLLUP(warehouse,
product)` is equivalent ...
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
