cloud-fan commented on a change in pull request #30212:
URL: https://github.com/apache/spark/pull/30212#discussion_r601254568
##########
File path: docs/sql-ref-syntax-qry-select-groupby.md
##########
@@ -32,7 +32,7 @@ When a FILTER clause is attached to an aggregate function,
only the matching row
GROUP BY group_expression [ , group_expression [ , ... ] ]
[ { WITH ROLLUP | WITH CUBE | GROUPING SETS (grouping_set [ , ...]) } ]
Review comment:
maybe we should change this to
```
GROUP BY group_expression [ , group_expression [ , ... ] ]
[ { WITH ROLLUP | WITH CUBE } ]
```
`GROUP BY GROUPING SETS (grouping_set [ , ...])` is covered by the syntax
below.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
