Github user jkbradley commented on the pull request: https://github.com/apache/spark/pull/4419#issuecomment-97247950 @hhbyyh Thanks for the update! It's looking good, but there are some cleanups to do. There are quite a few more I'd like to do, but since they are mostly Scala style issues and would take a long time to write out in comments, would you mind if I sent a PR to your PR? Perhaps you can update this PR based on my current comments first. Once that's done, I can send an update which does the small fixes.
--- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org