Github user jkbradley commented on a diff in the pull request: https://github.com/apache/spark/pull/5756#discussion_r29301064 --- Diff: mllib/src/main/scala/org/apache/spark/mllib/linalg/Vectors.scala --- @@ -116,6 +116,39 @@ sealed trait Vector extends Serializable { * with type `Double`. */ private[spark] def foreachActive(f: (Int, Double) => Unit) + + /** + * Number of active entries. Inactive entries are all zeros, while active entries could be zero. --- End diff -- Better phrasing: An "active entry" is an element which is explicitly stored, regardless of its value. Note that inactive entries have value 0.
--- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org