sarutak commented on a change in pull request #31964:
URL: https://github.com/apache/spark/pull/31964#discussion_r603019469



##########
File path: 
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/package.scala
##########
@@ -148,10 +148,10 @@ package object util extends Logging {
   }
 
   def quoteIfNeeded(part: String): String = {

Review comment:
       I looked into the following classes which use `quoteIfNeeded`
   
   * ResolveSessionCatalog.apply
   * IdentifierHelper.quoted
   * MultipartIdentifierHelper.quoted
   * DatabaseInSessionCatalog$.unapply
   * NamespaceHelper.quoted
   * Alias.sql
   * AttributeReference.sql
   * UnresolvedAttribute.sql
   * IdentifierImpl.toString
   * IdentifierHelper.quoted
   
   Finally, I think this change doesn't break existing behavior.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to