cloud-fan commented on a change in pull request #31984: URL: https://github.com/apache/spark/pull/31984#discussion_r603757191
########## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/dynamicpruning/PartitionPruning.scala ########## @@ -247,13 +246,15 @@ object PartitionPruning extends Rule[LogicalPlan] with PredicateHelper with Join // otherwise the pruning will not trigger var partScan = getPartitionTableScan(l, left) if (partScan.isDefined && canPruneLeft(joinType) && - hasPartitionPruningFilter(right)) { + hasPartitionPruningFilter(right) && + (canBroadcastBySize(right, conf) || hintToBroadcastRight(hint))) { Review comment: to confirm: the major change of this PR is to also consider broadcast hint? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org