tanelk commented on a change in pull request #31983:
URL: https://github.com/apache/spark/pull/31983#discussion_r604597457



##########
File path: sql/core/src/test/scala/org/apache/spark/sql/DataFrameSuite.scala
##########
@@ -2834,6 +2835,29 @@ class DataFrameSuite extends QueryTest
       df10.select(zip_with(col("array1"), col("array2"), (b1, b2) => 
reverseThenConcat2(b1, b2)))
     checkAnswer(test10, Row(Array(Row("cbaihg"), Row("fedlkj"))) :: Nil)
   }
+
+  test("SPARK-34882: Aggregate with multiple distinct null sensitive 
aggregators") {
+    spark.udf.register("countNulls", udaf(new Aggregator[JLong, JLong, JLong] {

Review comment:
       I added the `withUserDefinedFunction`, but I did not understand the 
first question.
   I added this udaf, because the built in aggregates, that are "null 
sensitive" (`First` and `Last`) gave unstable test results in the 
`SQLQueryTestSuite`.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to