Github user rxin commented on a diff in the pull request:

    https://github.com/apache/spark/pull/5762#discussion_r29306234
  
    --- Diff: 
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/basicOperators.scala
 ---
    @@ -310,6 +310,10 @@ case class Distinct(child: LogicalPlan) extends 
UnaryNode {
       override def output: Seq[Attribute] = child.output
     }
     
    +case class Coalesce(numPartitions: Int, shuffle: Boolean, child: 
LogicalPlan) extends UnaryNode {
    --- End diff --
    
    It's going to be super confusing with existing repartition and 
CoalescePartitions.
    
    How about 
    
    Repartition vs RepartitionByExpression? 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to