cloud-fan commented on a change in pull request #32010: URL: https://github.com/apache/spark/pull/32010#discussion_r605368101
########## File path: sql/core/src/test/resources/sql-tests/results/charvarchar.sql.out ########## @@ -663,6 +663,478 @@ Location [not included in comparison]/{warehouse_dir}/char_part Partition Provider Catalog +-- !query +create table str_tbl(c string, v string) using parquet +-- !query schema +struct<> +-- !query output + + + +-- !query +insert into str_tbl values + (null, null), + (null, 'S'), + ('N', 'N '), + ('Ne', 'Sp'), + ('Net ', 'Spa '), + ('NetE', 'Spar'), + ('NetEa ', 'Spark '), + ('NetEas ', 'Spark'), + ('NetEase', 'Spark-') +-- !query schema +struct<> +-- !query output + + + +-- !query +create table char_tbl4(c7 char(7), c8 char(8), v varchar(6), s string) using parquet +-- !query schema +struct<> +-- !query output + + + +-- !query +insert into char_tbl4 select c, c, v, c from str_tbl +-- !query schema +struct<> +-- !query output + + + +-- !query +select c7, c8, v, s from char_tbl4 +-- !query schema +struct<c7:string,c8:string,v:string,s:string> +-- !query output +N N N N +NULL NULL NULL NULL Review comment: The indentations do not match. We need to fix the test framework. @yaooqinn can you help with this later? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org