imback82 commented on a change in pull request #32032:
URL: https://github.com/apache/spark/pull/32032#discussion_r606034352



##########
File path: 
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/trees/TreeNode.scala
##########
@@ -830,7 +830,7 @@ abstract class TreeNode[BaseType <: TreeNode[BaseType]] 
extends Product {
 }
 
 trait LeafLike[T <: TreeNode[T]] { self: TreeNode[T] =>
-  override final def children: Seq[T] = Nil
+  override def children: Seq[T] = Nil

Review comment:
       @cloud-fan I am removing this `final` temporarily. If the approach of 
this PR is OK, I will add this back and refactor.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to