sunchao opened a new pull request #32082:
URL: https://github.com/apache/spark/pull/32082
Co-Authored-By: Chao Sun <sunc...@apple.com>
Co-Authored-By: Ryan Blue <rb...@netflix.com>
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines:
https://spark.apache.org/contributing.html
2. Ensure you have added or run the appropriate tests for your PR:
https://spark.apache.org/developer-tools.html
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g.,
'[WIP][SPARK-XXXX] Your PR title ...'.
4. Be sure to keep the PR description updated to reflect all changes.
5. Please write your PR title to summarize what this PR proposes.
6. If possible, provide a concise example to reproduce the issue for a
faster review.
7. If you want to add a new configuration, please read the guideline first
for naming configurations in
'core/src/main/scala/org/apache/spark/internal/config/ConfigEntry.scala'.
-->
### What changes were proposed in this pull request?
<!--
Please clarify what changes you are proposing. The purpose of this section
is to outline the changes and how this PR fixes the issue.
If possible, please consider writing useful notes for better and faster
reviews in your PR. See the examples below.
1. If you refactor some codes with changing classes, showing the class
hierarchy will help reviewers.
2. If you fix some SQL features, you can provide some references of other
DBMSes.
3. If there is design documentation, please add the link.
4. If there is a discussion in the mailing list, please add the link.
-->
This implements function resolution and evaluation for functions registered
through V2 FunctionCatalog
[SPARK-27658](https://issues.apache.org/jira/browse/SPARK-27658). In particular:
- Added documentation for how to define the "magic method" in
`ScalarFunction`.
- Added a new expression `ApplyFunctionExpression` which evaluates input by
delegating to `ScalarFunction.produceResult` method.
- added a new expression `V2Aggregator` which is a type of
`TypedImperativeAggregate`. It's a wrapper of V2 `AggregateFunction` and mostly
delegate methods to the implementation of the latter. It also uses plain Java
serde for intermediate state.
- Added function resolution logic for `ScalarFunction` and
`AggregateFunction` in `Analyzer`.
+ For `ScalarFunction` this checks if the magic method is implemented
through Java reflection, and create a `Invoke` expression if so. Otherwise, it
checks if the default `produceResult` is overridden. If so, it creates a
`ApplyFunctionExpression` which evaluates through `InternalRow`. Otherwise an
analysis exception is thrown.
+ For `AggregateFunction`, this checks if the `update` method is
overridden. If so, it converts it to `V2Aggregator`. Otherwise an analysis
exception is thrown similar to the case of `ScalarFunction`.
- Extended existing `InMemoryTableCatalog` to add the function catalog
capability. Also renamed it to `InMemoryCatalog` since it no longer only covers
tables.
**Note**: this currently can successfully detect whether a subclass
overrides the default `produceResult` or `update` method from the parent
interface **only for Java implementations**. It seems in Scala it's hard to
differentiate whether a subclass overrides a default method from its parent
interface. In this case, it will be a runtime error instead of analysis error.
Also this doesn't cover `V2SessionCatalog`. Ideally we want to extend that
to support function catalog as well but the APIs are different between V2
FunctionCatalog and those in V1 `SessionCatalog`.
### Why are the changes needed?
<!--
Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, you can clarify why it is a bug.
-->
As V2 FunctionCatalog APIs are finalized, we should integrate it with
function resolution and evaluation process so that they are actually useful.
### Does this PR introduce _any_ user-facing change?
<!--
Note that it means *any* user-facing change including all aspects such as
the documentation fix.
If yes, please clarify the previous behavior and the change this PR proposes
- provide the console output, description and/or an example to show the
behavior difference if possible.
If possible, please also clarify if this is a user-facing change compared to
the released Spark versions or within the unreleased branches such as master.
If no, write 'No'.
-->
Yes, now a function exposed through V2 FunctionCatalog can be analyzed and
evaluated.
### How was this patch tested?
<!--
If tests were added, say they were added here. Please make sure to add some
test cases that check the changes thoroughly including negative and positive
cases if possible.
If it was tested in a way different from regular unit tests, please clarify
how you tested step by step, ideally copy and paste-able, so that other
reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why
it was difficult to add.
-->
Added new unit tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
