Github user tedyu commented on the pull request:
https://github.com/apache/spark/pull/5725#issuecomment-97511381
<sup>**[sql/catalyst/src/main/java/org/apache/spark/sql/catalyst/expressions/UnsafeFixedWidthAggregationMap.java,
line 133
\[r14\]](https://reviewable.io:443/reviews/apache/spark/5725#-Jo56lmUPtN4oJEAxApu)**
([raw
file](https://github.com/apache/spark/blob/eeee512bd94d463f741170e904ae186e238f997c/sql/catalyst/src/main/java/org/apache/spark/sql/catalyst/expressions/UnsafeFixedWidthAggregationMap.java#L133)):</sup>
Please include writtenLength, unsafeRow.length and javaRow in the assertion
so that we have more information when debugging.
---
<sup>**[sql/catalyst/src/main/java/org/apache/spark/sql/catalyst/expressions/UnsafeRow.java,
line 148
\[r14\]](https://reviewable.io:443/reviews/apache/spark/5725#-Jo57pOAjJQa1nPxxd2y)**
([raw
file](https://github.com/apache/spark/blob/eeee512bd94d463f741170e904ae186e238f997c/sql/catalyst/src/main/java/org/apache/spark/sql/catalyst/expressions/UnsafeRow.java#L148)):</sup>
Condition doesn't match assertion message w.r.t. <=
---
<sup>**[unsafe/src/main/java/org/apache/spark/unsafe/array/ByteArrayMethods.java,
line 23
\[r14\]](https://reviewable.io:443/reviews/apache/spark/5725#-Jo5AmeniFC0_bDQdiyb)**
([raw
file](https://github.com/apache/spark/blob/eeee512bd94d463f741170e904ae186e238f997c/unsafe/src/main/java/org/apache/spark/unsafe/array/ByteArrayMethods.java#L23)):</sup>
Declare this class static ?
---
<sup>**[unsafe/src/main/java/org/apache/spark/unsafe/array/LongArray.java,
line 26
\[r14\]](https://reviewable.io:443/reviews/apache/spark/5725#-Jo5B0VcBmjKX4TnrZD7)**
([raw
file](https://github.com/apache/spark/blob/eeee512bd94d463f741170e904ae186e238f997c/unsafe/src/main/java/org/apache/spark/unsafe/array/LongArray.java#L26)):</sup>
nit: in-heap -> on-heap
---
<sup>**[unsafe/src/main/java/org/apache/spark/unsafe/bitset/BitSet.java,
line 24
\[r14\]](https://reviewable.io:443/reviews/apache/spark/5725#-Jo5BT5TTxBoPNV_juFI)**
([raw
file](https://github.com/apache/spark/blob/eeee512bd94d463f741170e904ae186e238f997c/unsafe/src/main/java/org/apache/spark/unsafe/bitset/BitSet.java#L24)):</sup>
https://docs.oracle.com/javase/7/docs/api/java/util/BitSet.html doesn't
serve your needs ?
---
<sup>**[unsafe/src/main/java/org/apache/spark/unsafe/bitset/BitSetMethods.java,
line 75
\[r14\]](https://reviewable.io:443/reviews/apache/spark/5725#-Jo5C4Ty7HYh-hvVPSEb)**
([raw
file](https://github.com/apache/spark/blob/eeee512bd94d463f741170e904ae186e238f997c/unsafe/src/main/java/org/apache/spark/unsafe/bitset/BitSetMethods.java#L75)):</sup>
Maybe use something similar to
http://www.docjar.com/docs/api/sun/misc/Unsafe.html#getInt(Object, long) for
speedup ?
---
---
Comments from the [review on
Reviewable.io](https://reviewable.io:443/reviews/apache/spark/5725)
<!-- Sent from Reviewable.io -->
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
