harupy commented on a change in pull request #32245: URL: https://github.com/apache/spark/pull/32245#discussion_r616312217
########## File path: python/pyspark/ml/classification.py ########## @@ -3151,7 +3151,7 @@ def func(predictions): predArray.append(x) return Vectors.dense(predArray) - rawPredictionUDF = udf(func) Review comment: Should I add a test here to ensure that the `rawPrediction` column is no longer `string` https://github.com/apache/spark/blob/0494dc90af48ce7da0625485a4dc6917a244d580/python/pyspark/ml/tests/test_algorithms.py#L108-L117 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org