WeichenXu123 commented on a change in pull request #32245:
URL: https://github.com/apache/spark/pull/32245#discussion_r617131801



##########
File path: python/pyspark/ml/tests/test_algorithms.py
##########
@@ -115,6 +115,7 @@ def test_output_columns(self):
         model = ovr.fit(df)
         output = model.transform(df)
         self.assertEqual(output.columns, ["label", "features", 
"rawPrediction", "prediction"])
+        self.assertIsInstance(output.schema["rawPrediction"].dataType, 
VectorUDT)

Review comment:
       add a separate unit test with name "fix SPARK-35142:..." will be better.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to