dongjoon-hyun commented on a change in pull request #32167: URL: https://github.com/apache/spark/pull/32167#discussion_r618083727
########## File path: sql/core/src/test/scala/org/apache/spark/sql/SQLQuerySuite.scala ########## @@ -404,6 +404,9 @@ class SQLQuerySuite extends QueryTest with SharedSparkSession with AdaptiveSpark checkAnswer( sql("SELECT COALESCE(null, null, null)"), Row(null)) + checkAnswer( + sql("SELECT COALESCE(s, n) FROM nullStrings"), Review comment: WDYT about the above @HyukjinKwon 's comment, @zengruios ? Is this PR different because this is `String`? If this is already covered, shall we close this PR? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org