sigmod commented on a change in pull request #32247: URL: https://github.com/apache/spark/pull/32247#discussion_r618101375
########## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala ########## @@ -3790,9 +3793,9 @@ object UpdateOuterReferences extends Rule[LogicalPlan] { } def apply(plan: LogicalPlan): LogicalPlan = { - plan resolveOperators { + plan.resolveOperatorsWithPruning(_.containsAllPatterns(PLAN_EXPRESSION, FILTER), ruleId) { case f @ Filter(_, a: Aggregate) if f.resolved => - f transformExpressions { + f.transformExpressionsWithPruning(_.containsPattern(PLAN_EXPRESSION), ruleId) { Review comment: PlanExpression covers both logical and physical, so that we can use it in a few physical rules too in later PRs without adding new bits. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org