cloud-fan commented on a change in pull request #32032:
URL: https://github.com/apache/spark/pull/32032#discussion_r619266693
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/views.scala
##########
@@ -48,29 +48,41 @@ import org.apache.spark.sql.util.SchemaUtils
* @param properties the properties of this view.
* @param originalText the original SQL text of this view, can be None if this
view is created via
* Dataset API.
- * @param child the logical plan that represents the view; this is used to
generate the logical
- * plan for temporary view and the view schema.
+ * @param plan the logical plan that represents the view; this is used to
generate the logical
+ * plan for temporary view and the view schema.
* @param allowExisting if true, and if the view already exists, noop; if
false, and if the view
* already exists, throws analysis exception.
* @param replace if true, and if the view already exists, updates it; if
false, and if the view
* already exists, throws analysis exception.
* @param viewType the expected view type to be created with this command.
+ * @param isAnalyzed whether this command is analyzed or not.
*/
case class CreateViewCommand(
name: TableIdentifier,
userSpecifiedColumns: Seq[(String, Option[String])],
comment: Option[String],
properties: Map[String, String],
originalText: Option[String],
- child: LogicalPlan,
+ plan: LogicalPlan,
allowExisting: Boolean,
replace: Boolean,
- viewType: ViewType)
- extends LeafRunnableCommand {
+ viewType: ViewType,
+ isAnalyzed: Boolean = false) extends RunnableCommand with
AnalysisOnlyCommand {
import ViewHelper._
- override def innerChildren: Seq[QueryPlan[_]] = Seq(child)
+ override protected def withNewChildrenInternal(
+ newChildren: IndexedSeq[LogicalPlan]): CreateViewCommand = {
+ assert(!isAnalyzed)
+ copy(plan = newChildren.head)
+ }
+
+ override def innerChildren: Seq[QueryPlan[_]] = Seq(plan)
Review comment:
shall we only include it as inner children only when `isAnalyzed =
true`? Maybe we can put it in the base class, as it's better to include the
plan in inner children to show it in the UI.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
