cloud-fan commented on a change in pull request #32210:
URL: https://github.com/apache/spark/pull/32210#discussion_r619300886
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala
##########
@@ -385,6 +385,16 @@ object SQLConf {
.booleanConf
.createWithDefault(true)
+ val SHUFFLEDHASHJOIN_FALLBACK_ENABLED =
+ buildConf("spark.sql.join.enableShuffledHashJoinFallback")
+ .internal()
+ .doc("When true, enable sort-based fallback for shuffled hash join. " +
+ "The sort-based fallback is to use sort merge join when there is no
enough memory " +
+ "to build hash table for shuffled hash join. This can help avoid task
OOM automatically.")
+ .version("3.2.0")
+ .booleanConf
+ .createWithDefault(false)
Review comment:
Seems a bit overkill to add a config for this. People can just flip the
existing config to prefer SMJ, then SHJ will never be used.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
