c21 commented on a change in pull request #32198:
URL: https://github.com/apache/spark/pull/32198#discussion_r619978928
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/FileFormatDataWriter.scala
##########
@@ -52,19 +53,35 @@ abstract class FileFormatDataWriter(
protected val statsTrackers: Seq[WriteTaskStatsTracker] =
description.statsTrackers.map(_.newTaskInstance())
- protected def releaseResources(): Unit = {
+ /** Release resources of `currentWriter`. */
+ protected def releaseCurrentWriter(): Unit = {
if (currentWriter != null) {
try {
currentWriter.close()
+ statsTrackers.foreach(_.closeFile(currentWriter.path()))
} finally {
currentWriter = null
}
}
}
- /** Writes a record */
+ /** Release all resources. */
+ protected def releaseResources(): Unit = {
+ // Call `releaseCurrentWriter()` by default, as this is the only resource
to be released.
+ releaseCurrentWriter()
+ }
+
+ /** Writes a record. */
def write(record: InternalRow): Unit
Review comment:
We have [data source v2 writers depend on this and has a
counter](https://github.com/apache/spark/blob/master/sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/WriteToDataSourceV2Exec.scala#L390-L394),
and this `write` is part of `DataWriter` API. Shall we change it later?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
