AngersZhuuuu commented on a change in pull request #32314:
URL: https://github.com/apache/spark/pull/32314#discussion_r620894344
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/intervalExpressions.scala
##########
@@ -473,13 +497,26 @@ case class DivideDTInterval(
}
override def nullSafeEval(interval: Any, num: Any): Any = {
+ checkDivideOverflow(interval.asInstanceOf[Long], Long.MinValue, right, num)
evalFunc(interval.asInstanceOf[Long], num)
}
override def doGenCode(ctx: CodegenContext, ev: ExprCode): ExprCode =
right.dataType match {
case _: IntegralType =>
val math = classOf[LongMath].getName
- defineCodeGen(ctx, ev, (m, n) => s"$math.divide($m, $n,
java.math.RoundingMode.HALF_UP)")
+ val micros = left.genCode(ctx)
+ val num = right.genCode(ctx)
+ val checkIntegralDivideOverflow =
+ s"""
+ |if (${micros.value} == ${Long.MinValue}L && ${num.value} == -1L)
+ | throw QueryExecutionErrors.overflowInIntegralDivideError();
+ |""".stripMargin
+
+ nullSafeCodeGen(ctx, ev, (m, n) =>
+ s"""
+ |$checkIntegralDivideOverflow
Review comment:
Done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
