ulysses-you commented on a change in pull request #32355:
URL: https://github.com/apache/spark/pull/32355#discussion_r620942003
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/SparkStrategies.scala
##########
@@ -139,6 +139,7 @@ abstract class SparkStrategies extends
QueryPlanner[SparkPlan] {
object JoinSelection extends Strategy
with PredicateHelper
with JoinSelectionHelper {
+ private val hintErrorHandler = conf.hintErrorHandler
Review comment:
It's a point. How about make a new rule at Optimizer `Finish Analysis`
batch to check if join is illegal. Move to Optimizer is to avoid effect like
`EliminateOuterJoin`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
