[GitHub] [spark] AngersZhuuuu commented on a change in pull request #32266: [SPARK-35111][SQL] Support Cast string to year-month interval

[GitBox]

AngersZhuuuu commented on a change in pull request #32266:
URL: https://github.com/apache/spark/pull/32266#discussion_r622029023



##########
File path: 
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/IntervalUtils.scala
##########
@@ -93,13 +95,22 @@ object IntervalUtils {
 
   private val yearMonthPattern = "^([+|-])?(\\d+)-(\\d+)$".r
 
+  def fromYearMonthString(input: UTF8String): CalendarInterval = {
+    if (input == null || input.toString == null) {
+      throw new IllegalArgumentException("Interval year-month string must be 
not null")

Review comment:
       Remove， `Cast` can keep null safe here

##########
File path: 
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/Cast.scala
##########
@@ -1354,6 +1362,13 @@ abstract class CastBase extends UnaryExpression with 
TimeZoneAwareExpression wit
 
   }
 
+  private[this] def castToYearMonthIntervalCode(from: DataType): CastFunction 
= from match {
+    case StringType =>
+      val util = IntervalUtils.getClass.getCanonicalName.stripSuffix("$")
+      (c, evPrim, evNull) =>
+        code"""$evPrim = $util.fromYearMonthString($c).months;""".stripMargin

Review comment:
       done




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org