cloud-fan commented on a change in pull request #32266: URL: https://github.com/apache/spark/pull/32266#discussion_r622334319
########## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/IntervalUtils.scala ########## @@ -92,6 +93,31 @@ object IntervalUtils { } private val yearMonthPattern = "^([+|-])?(\\d+)-(\\d+)$".r + private val yearMonthStringPattern = + "^(INTERVAL\\s+)([+|-])*?(')([+|-])?(\\d+)-(\\d+)(')(\\s+YEAR TO MONTH)$".r Review comment: I still don't understand `([+|-])*?`. Do we support `INTERVAL ++'1-1' YEAR TO MONTH`? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org