viirya commented on a change in pull request #31944:
URL: https://github.com/apache/spark/pull/31944#discussion_r622376735
##########
File path:
external/kafka-0-10-sql/src/main/scala/org/apache/spark/sql/kafka010/KafkaMicroBatchStream.scala
##########
@@ -133,6 +137,10 @@ private[kafka010] class KafkaMicroBatchStream(
override def toString(): String = s"KafkaV2[$kafkaOffsetReader]"
+ override def metrics(latestOffset: Optional[Offset]): ju.Map[String, String]
= {
+ KafkaMicroBatchStream.metrics(latestOffset, latestPartitionOffsets)
Review comment:
Because `MicroBatchStream` has an API `latestOffset` which is latest
offset available. I guess we need to be more clear about the API item to avoid
confusing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
