cloud-fan commented on a change in pull request #32361:
URL: https://github.com/apache/spark/pull/32361#discussion_r622830623
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/CheckpointFileManager.scala
##########
@@ -83,6 +83,9 @@ trait CheckpointFileManager {
/** Is the default file system this implementation is operating on the local
file system. */
def isLocal: Boolean
+
+ /** Returns the qualified path of the checkpoint path. */
+ def getQualifiedCheckpointPath(): Path
}
Review comment:
not related to this PR: I think it's better to document clearly that
whether the path parameter should be relative or qualified, in all the methods
of this trait, even if this is just an internal API.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
