srowen commented on a change in pull request #32415:
URL: https://github.com/apache/spark/pull/32415#discussion_r624608038
##########
File path: pom.xml
##########
@@ -172,7 +172,7 @@
<fasterxml.jackson.version>2.12.2</fasterxml.jackson.version>
<snappy.version>1.1.8.4</snappy.version>
<netlib.java.version>1.1.2</netlib.java.version>
- <netlib.ludovic.dev.version>1.3.2</netlib.ludovic.dev.version>
+ <netlib.ludovic.dev.version>2-SNAPSHOT</netlib.ludovic.dev.version>
Review comment:
Ideally we don't depend on a snapshot version - fine if this is in
progress and 2.0 will be the final version referenced here.
##########
File path: mllib/pom.xml
##########
@@ -156,19 +156,6 @@
</dependency>
</dependencies>
- <profiles>
Review comment:
That's cool if we don't need any LGPL shims included in the build to use
the end-user's OpenBLAS, MKL. Yes, as you do, leave it in the parent POM as
'deprecated'
##########
File path: pom.xml
##########
@@ -298,6 +298,18 @@
<enabled>false</enabled>
</snapshots>
</repository>
+
+ <!-- THIS SHOULD NOT BE MERGED!!! THIS IS A TEMPORARY WORKAROUND!!! -->
Review comment:
Yep, fine for testing
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
